Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure PodScheduled conditions #1244

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Oct 23, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1243

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Ensure PodScheduled conditions

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2024
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 0659e4d
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6718ce02676ad100080ba010

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 23, 2024
@wzshiming wzshiming changed the title Avoid PodScheduled overwriting Ensure PodScheduled conditions Oct 23, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2024
@wzshiming wzshiming merged commit 45e59c0 into kubernetes-sigs:main Oct 24, 2024
26 of 27 checks passed
@wzshiming wzshiming deleted the fix/pod-scheduled branch October 24, 2024 03:10
@wzshiming
Copy link
Member Author

/cherrypick release-0.6

@k8s-infra-cherrypick-robot

@wzshiming: new pull request created: #1247

In response to this:

/cherrypick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid PodScheduled overwriting
3 participants