Minor refactor to scale-up orchestrator for more re-usability #7649
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/S
kawych
force-pushed
the
dws-htn
branch
2 times, most recently
from
79f141d to
86d6ac1
Compare
| @@ -188,7 +188,8 @@ func (e *scaleUpExecutor) executeScaleUp( | |||
| return nil | |||
| } | |||
|
|
|||
| func combineConcurrentScaleUpErrors(errs []errors.AutoscalerError) errors.AutoscalerError { | |||
| // CombineConcurrentScaleUpErrors returns combined scale-up error to report after multiple concurrent scale-ups might haver failed. | |||
| func CombineConcurrentScaleUpErrors(errs []errors.AutoscalerError) errors.AutoscalerError { | |||
There was a problem hiding this comment.
Wouldn't it make more sense as a part of the errors package?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kawych The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/L
| @@ -131,3 +133,63 @@ func (e autoscalerErrorImpl) Type() AutoscalerErrorType { | |||
| func (e autoscalerErrorImpl) AddPrefix(msg string, args ...interface{}) AutoscalerError { | |||
| return autoscalerErrorImpl{errorType: e.errorType, wrappedErr: e, msg: fmt.Sprintf(msg, args...)} | |||
| } | |||
|
|
|||
| // CombineConcurrentScaleUpErrors returns combined scale-up error to report after multiple concurrent scale-ups might haver failed. | |||
| func CombineConcurrentScaleUpErrors(errs []AutoscalerError) AutoscalerError { | |||
There was a problem hiding this comment.
I don't think there's anything scale up specific here, can you rename this to just CombineConcurrentErrors? Or even CombineErrors if you also remove the word "concurrent" from line 173?
kawych
force-pushed
the
dws-htn
branch
5 times, most recently
from
c936440 to
a80833c
Compare
What type of PR is this?
What this PR does / why we need it:
It's a minor refactor that makes it easier to re-use parts of the core scale-up logic while replacing other parts:
Special notes for your reviewer:
Does this PR introduce a user-facing change?