Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a github token for publishing-bot #5950

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Add a github token for publishing-bot #5950

merged 1 commit into from
Oct 10, 2023

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Oct 10, 2023

Related to:

Sync existing Github token to trusted GKE cluster prow-build-trusted. The token will be consumed by a prowjob

@ameukam
Add a github token for publishing-bot
1a56184 
Related to:
  - kubernetes/publishing-bot#353

Sync existing Github token to trusted GKE cluster `prow-build-trusted`.
The token will be consumed by a prowjob

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and cpanato October 10, 2023 11:50
@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 10, 2023
@ameukam
Copy link
Member Author

ameukam commented Oct 10, 2023

cc @dims @akhilerm

cpanato
cpanato approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@ameukam
Copy link
Member Author

ameukam commented Oct 10, 2023

FYI @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot merged commit fc7a0b6 into kubernetes:main Oct 10, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 10, 2023
@akhilerm
Copy link
Member

Thank you @ameukam

ameukam added a commit to ameukam/k8s.io that referenced this pull request Oct 10, 2023
@ameukam
gcp: Allow access to secret from trusted build cluster
9248064 
- Follow-up of:
  - kubernetes#5950

Ensure secret is accessible by the service account for KES running prow-build-trusted.

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam ameukam mentioned this pull request Oct 10, 2023
Merged
@ameukam
Copy link
Member Author

ameukam commented Oct 11, 2023

Token is available on k8s-infra-prow-build-trusted:

k8s-release-publishing-bot-github-token        Opaque                                1      2m31s

@ameukam ameukam mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@aojea aojea Awaiting requested review from aojea

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
4 participants
@ameukam @k8s-ci-robot @akhilerm @cpanato