Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd-manager: push staging images to our own project #33399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

etcd-manager: push staging images to our own project #33399

wants to merge 1 commit into from

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Sep 1, 2024 •
edited
Loading

This seems to be what other projects are doing now (?)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justinsb
Once this PR has been reviewed and has the lgtm label, please assign chases2 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 1, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 1, 2024
@justinsb justinsb force-pushed the etcd_manager_image_staging_job branch from 61a3acc to d32c690 Compare September 1, 2024 13:43
@justinsb justinsb changed the title etcd manager image staging job etcd-manager: push staging images to our own project Sep 1, 2024
@justinsb justinsb mentioned this pull request Sep 1, 2024
Merged
justinsb
justinsb commented Sep 1, 2024
View reviewed changes
config/jobs/image-pushing/k8s-staging-etcd-manager.yaml
- --project=k8s-staging-images
- --scratch-bucket=gs://k8s-staging-images-gcb
- --project=k8s-staging-etcd-manager
- --scratch-bucket=gs://k8s-staging-etcd-manager-gcb
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this bucket does not seem to exist...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turnout we no longer can create GCR repositories with the ./ensure-staging-storage.sh script. They are now hosted on AR. https://cloud.google.com/container-registry/docs/deprecations/container-registry-deprecation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@airbornepony airbornepony Awaiting requested review from airbornepony

@dims dims Awaiting requested review from dims

Assignees
No one assigned
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @k8s-ci-robot @ameukam