Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e test script and expand feature focus for volume group snapshots #33417

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

manishym
Copy link
Contributor

@manishym manishym commented Sep 4, 2024

Change the e2e test script in the sig-storage-kind.yaml to use 'run_group_snapshot_e2e.sh' the run_group_snapshot_e2e.sh script installs group snapshot CRD and then runs group snapshot e2e tests along with the existing alpha beta feature tests.

This update is part of ongoing efforts to enhance testing for volume group snapshot capabilities in Kubernetes SIG Storage.

PR in k/k: kubernetes/kubernetes#126326

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 4, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @manishym!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @manishym. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/jobs sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 4, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2024
@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2024
…shots

Change the e2e test script in the sig-storage-kind.yaml to use 'run_group_snapshot_e2e.sh'
the run_group_snapshot_e2e.sh script installs group snapshot CRD and
then runs group snapshot e2e tests along with the existing alpha beta
feature tests.

This update is part of ongoing efforts to enhance testing for volume group snapshot capabilities in Kubernetes SIG Storage.

Signed-off-by: Manish <[email protected]>
@gnufied
Copy link
Member

gnufied commented Sep 12, 2024

/assign

@xing-yang
Copy link
Contributor

/lgtm
/approve

Merging this PR so that we can test kubernetes/kubernetes#126326.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manishym, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit c2285ec into kubernetes:master Sep 27, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@manishym: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-storage-kind.yaml using file config/jobs/kubernetes/sig-storage/sig-storage-kind.yaml

In response to this:

Change the e2e test script in the sig-storage-kind.yaml to use 'run_group_snapshot_e2e.sh' the run_group_snapshot_e2e.sh script installs group snapshot CRD and then runs group snapshot e2e tests along with the existing alpha beta feature tests.

This update is part of ongoing efforts to enhance testing for volume group snapshot capabilities in Kubernetes SIG Storage.

PR in k/k: kubernetes/kubernetes#126326

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants