Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous sentence about topologySpreadConstraints #47947

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ambiguous sentence about topologySpreadConstraints #47947

wants to merge 1 commit into from

Conversation

scheduler-tester
Copy link
Contributor

Description

Clarified the ambiguous sentence regarding the conditions when multiple topologySpreadConstraints are set.

Issue

Fixes: kubernetes/kubernetes#127305

/language en
/sig docs scheduling

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 04b6fdf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66e7910b3597a60008c43b6f
😎 Deploy Preview https://deploy-preview-47947--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Sep 16, 2024

We avoid Markdown in commit messages, so:
/retitle Fix ambiguous sentence about topologySpreadConstraints

@k8s-ci-robot k8s-ci-robot changed the title Fix the ambiguous sentence about topologySpreadConstraints Fix ambiguous sentence about topologySpreadConstraints Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@Princesso Princesso Awaiting requested review from Princesso

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Scheduling
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Scheduler not working as expected when multiple topologySpreadConstraints are set
3 participants
@scheduler-tester @k8s-ci-robot @sftim