Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Fix alphabetical order of translation IDs. #49439

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apoorvapendse
Copy link
Contributor

Fixes #49409.

Description

Whille working on #48958, I found this bug.
#48958 (comment).

Closes: #49409.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from tengqm January 15, 2025 04:57
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 15, 2025
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2025
Copy link

netlify bot commented Jan 15, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit be32474
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6788885142bc930008f63e7a
😎 Deploy Preview https://deploy-preview-49439--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@niranjandarshann
Copy link
Contributor

@apoorvapendse Thank you for your PR . Give the valid commit message.

@apoorvapendse
Copy link
Contributor Author

@niranjandarshann, could you please elaborate, I don't understand what's missing here.

@niranjandarshann
Copy link
Contributor

@niranjandarshann, could you please elaborate, I don't understand what's missing here.

Commit message guidelines typically recommend avoiding a period at the end of the subject line.

@niranjandarshann
Copy link
Contributor

remove . at the end of commit message.

@apoorvapendse
Copy link
Contributor Author

apoorvapendse commented Jan 16, 2025

I see, thanks for pointing that out @niranjandarshann .
Some other projects I contribute to prefer to treat commit summary (the first line) as a sentence which ends with a period.

I've followed these guidelines and hope it matches the preferred commit structure.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix alphabetical order of en.toml translation IDs
3 participants