Fix: Bypass Provision Manager for s390x kubevirtci publish #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now, we are updating kubevirt-prow/release/kubevirt/kubevirtci/latest file after amd64 images are published, independent of s390x image publish failure. Provision manager assumes s390x images are available with the tag in the latest file and tries to retag them when no diffs between the current code and the tag. But this fails, when no s390x image exists with tag in the latest file Signed-off-by: chandramerla <[email protected]>
kubevirt-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dosubot
bot
added
kind/bug
wg/arch-s390x
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bypass Provision Manager for s390x kubevirtci publish
Currently we are updating kubevirt-prow/release/kubevirt/kubevirtci/latest file after amd64 images are published, independent of s390x image publish failure. Provision manager assumes s390x images are available with the tag in the latest file and tries to retag them when no diffs between the current code and the tag. But this fails, when no s390x image exists with tag in the latest file.
This fixes failures of prow build which publishes kubevirtci images of s390x arch, where build failed as source image tag provision manager tries to re-tag doesn't exist in container image repository:
publish-kubevirtci-s390x/1887109512381337600
publish-kubevirtci-s390x/1886536840723304448
publish-kubevirtci-s390x/1884887500791484416
Special notes for your reviewer:
/cc @brianmcarey
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.