-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add command-line tool admiralctl join&unjoin #302
Closed
miraclejzd
wants to merge
25
commits into
kubewharf:main
from
miraclejzd:feat-admiralctl-join&unjoin
Closed
feat: add command-line tool admiralctl join&unjoin #302
miraclejzd
wants to merge
25
commits into
kubewharf:main
from
miraclejzd:feat-admiralctl-join&unjoin
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add isInitialize parameter to OnAdd method
- remove ch
- remove the intermediate output
- add a new function to create the fed factory without password
- modify the docstring of o.Namespace - add fmt.Printf when Join is done.
Zhida Jiang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, users need to manually create Secret and FederatedCluster resources through YAML files to add member clusters, and this file-based approach is not very convenient. Thanks to the work in #202, the command-line tool admiralctl has taken shape. In this proposal, I am building upon this work by introducing a new subcommand, admiralctl join, corresponding to #260. With this command, users can add member clusters via the command line.
Motivation
With the command-line tool, users can conveniently add member clusters without the need to manually create Secret and FederatedCluster resources.
Proposal
Command line tool framework selection
Similar to #202, utilizing cobra as the framework for the command-line tool.
admiralctl join
subcommandReady
.Command design
admiralctl unjoin
subcommandCommand design