Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util): specify user agent in kube clients #98

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

SOF3
Copy link
Member

@SOF3 SOF3 commented Feb 25, 2025

No description provided.

@SOF3 SOF3 added the enhancement New feature or request label Feb 25, 2025
Copy link

@mingyuanzhu mingyuanzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 41.09%. Comparing base (4dde521) to head (16076c9).

Files with missing lines Patch % Lines
util/kube/client.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   41.11%   41.09%   -0.02%     
==========================================
  Files         102      102              
  Lines        7122     7125       +3     
==========================================
  Hits         2928     2928              
- Misses       4035     4038       +3     
  Partials      159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DeliangFan DeliangFan enabled auto-merge February 25, 2025 03:35
@DeliangFan
Copy link
Collaborator

/LGTM

@DeliangFan DeliangFan added this pull request to the merge queue Feb 25, 2025
Merged via the queue into kubewharf:main with commit 012a898 Feb 25, 2025
5 checks passed
@SOF3 SOF3 deleted the kube-user-agent branch February 25, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants