adds pagerduty as an endpoint #781 #787
Open
+986
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution, I will try to take a Look on your PR this Week |
resnostyle
force-pushed
the
add-pagerduty-support
branch
from
b17bb87 to
5b55497
Compare
|
I'll need to make some additional changes, but wanted to get an idea of if this is a good direction so far. |
fjogeleit
reviewed
Mar 1, 2025
pkg/target/pagerduty/pagerduty.go
Outdated
|
|
||
| // Create a unique key for tracking incidents | ||
| func incidentKey(result v1alpha2.PolicyReportResult) string { | ||
| key := result.Policy |
There was a problem hiding this comment.
you might want to add the rule as well. One policy can have multiple rules which fail against one resource.
fjogeleit
reviewed
Mar 1, 2025
pkg/target/pagerduty/pagerduty.go
Outdated
| } | ||
|
|
||
| // Store the incident ID for later resolution | ||
| p.incidents.Store(key, resp.Id) |
There was a problem hiding this comment.
What happens when the pod restarts or you run it in a HA setup? This approach not working really.
You also missing the case when a Policy or Resource is deleted. Then the result is just removed from the report.
Signed-off-by: B Pearson <[email protected]>
resnostyle
force-pushed
the
add-pagerduty-support
branch
from
51dd6c6 to
d909403
Compare
for multiple clusters Signed-off-by: B Pearson <[email protected]>
resnostyle
force-pushed
the
add-pagerduty-support
branch
from
d909403 to
e1ba6a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.