-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to PHPUnit 10 #171
Conversation
Signed-off-by: Ion Bazan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unable to run it locally to re-generate the baseline file
Something like docker run --rm -ti -v $(pwd):/app -w /app php:8.1 ./vendor/bin/psalm --no-cache --set-baseline=psalm-baseline.xml
?
Signed-off-by: Ion Bazan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of tiny changes needed, then good to go!
Thanks @IonBazan!
Signed-off-by: Ion Bazan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @IonBazan!
Description
Upgrading to PHPUnit 10 and Psalm 5.7 (required for
sebastian/diff
v5), converting all@requires
@covers
and@dataProvider
annotations to PHP 8 attributes. Obsolete annotations like@requires PHP >= 8.0
were removed as we already require PHP 8.1 incomposer.json
I'm not sure how to proceed with Psalm errors here - I am unable to run it locally to re-generate the baseline file. @Ocramius let me know what you think.
Replaces #170