Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PHPUnit 10 #171

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Upgrade to PHPUnit 10 #171

merged 3 commits into from
Feb 23, 2023

Conversation

IonBazan
Copy link
Contributor

@IonBazan IonBazan commented Feb 20, 2023

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Upgrading to PHPUnit 10 and Psalm 5.7 (required for sebastian/diff v5), converting all @requires @covers and @dataProvider annotations to PHP 8 attributes. Obsolete annotations like @requires PHP >= 8.0 were removed as we already require PHP 8.1 in composer.json

I'm not sure how to proceed with Psalm errors here - I am unable to run it locally to re-generate the baseline file. @Ocramius let me know what you think.

Replaces #170

Signed-off-by: Ion Bazan <[email protected]>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unable to run it locally to re-generate the baseline file

Something like docker run --rm -ti -v $(pwd):/app -w /app php:8.1 ./vendor/bin/psalm --no-cache --set-baseline=psalm-baseline.xml?

Signed-off-by: Ion Bazan <[email protected]>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tiny changes needed, then good to go!

Thanks @IonBazan!

phpunit.xml.dist Outdated Show resolved Hide resolved
phpunit.xml.dist Outdated Show resolved Hide resolved
psalm-baseline.xml Show resolved Hide resolved
Signed-off-by: Ion Bazan <[email protected]>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IonBazan!

@Ocramius Ocramius merged commit 0f3dd23 into laminas:4.9.x Feb 23, 2023
@IonBazan IonBazan deleted the phpunit-10 branch February 23, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants