Skip to content

Commit

Permalink
ci: fix Python Arm build (#3409)
Browse files Browse the repository at this point in the history
We were using deprecated 2_24 for ARM, but that seems to have some
issues. Dropping down to 2_17 for now to keep wide support, as I believe
some of the popular cloud linuxes don't have >=2.28 glibc.
  • Loading branch information
wjones127 authored Jan 23, 2025
1 parent 3cb54c6 commit 3c82243
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
9 changes: 2 additions & 7 deletions .github/workflows/build_linux_wheel/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,7 @@ runs:
args: ${{ inputs.args }}
before-script-linux: |
set -e
apt install -y unzip
if [ $(uname -m) = "x86_64" ]; then
PROTOC_ARCH="x86_64"
else
PROTOC_ARCH="aarch_64"
fi
curl -L https://github.com/protocolbuffers/protobuf/releases/download/v24.4/protoc-24.4-linux-$PROTOC_ARCH.zip > /tmp/protoc.zip \
yum install -y openssl-devel clang \
&& curl -L https://github.com/protocolbuffers/protobuf/releases/download/v24.4/protoc-24.4-linux-aarch_64.zip > /tmp/protoc.zip \
&& unzip /tmp/protoc.zip -d /usr/local \
&& rm /tmp/protoc.zip
5 changes: 4 additions & 1 deletion .github/workflows/pypi-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@ jobs:
manylinux: "2_28"
extra_args: "--features fp16kernels"
- platform: aarch64
manylinux: "2_24"
manylinux: "2_17"
extra_args: ""
- platform: aarch64
manylinux: "2_28"
extra_args: "--features fp16kernels"
# We don't build fp16 kernels for aarch64, because it uses
# cross compilation image, which doesn't have a new enough compiler.
runs-on: "ubuntu-22.04"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ jobs:
- uses: ./.github/workflows/build_linux_wheel
with:
arm-build: "true"
manylinux: "2_24"
manylinux: "2_28"
- name: Install dependencies
run: |
sudo apt update -y -qq
Expand Down

0 comments on commit 3c82243

Please sign in to comment.