Fix Laravel installer on Windows WSL #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR #376 should already fixed the issue for PHP 8.3 and below. |
|
@crynobone It didn't fix it for me on Windows WSL though, the installation crashes with an exception even though I had the If the consensus is that this is user error on my side, that's fine, it was easy enough to resolve anyway - I just would hate for new Laravel devs on Windows to give up when the installer crashes for them without a clear indication of why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #384
The missing
mb_trim()function causeslaravel newto crash on Windows WSL when running a PHP version lower than 8.4.Considering the command isn't being used to strip multi-byte characters,
rtrimshould work fine and won't lead to any issues for users who are not yet on PHP 8.4.