Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic Beanstalk Support #194

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fny
Copy link
Contributor

@fny fny commented May 9, 2015

This commit adds AWS Elastic Beanstalk support through figaro eb:set. All of the related option accoutrements are included too.

I also extracted the command-related expectations into an expect_ran helper to DRY things up a bit.

Growing Plant

Fixes #193. Passing version of #187. :bowtie:

@fny fny force-pushed the elastic-beanstalk-support branch from 30c0940 to 3120d16 Compare May 9, 2015 01:13
@fny fny force-pushed the elastic-beanstalk-support branch from 3120d16 to 9c2f371 Compare May 10, 2015 14:07
@fny
Copy link
Contributor Author

fny commented May 15, 2015

Not sure what's up, but there's a test from something outside the scope of my changes that's failing on the latest build (weirdly 264.11 alone). Everything was passing the first time I made this PR (Build 263). 😕

@BilalBudhani
Copy link

@fny any luck in making this test pass?

@fny fny force-pushed the elastic-beanstalk-support branch from 9c2f371 to f3009ed Compare May 26, 2015 13:32
@fny
Copy link
Contributor Author

fny commented May 26, 2015

Yes, but I cheated. I just pushed a change to the README, and all is well.

It looks like there's a bug elsewhere Figaro that makes that spec randomly fail on Ruby 1.9.3 and Rails 3.2: See #200.

@hiattp
Copy link

hiattp commented Aug 12, 2015

Would love to see this merged!

@guirl
Copy link

guirl commented Oct 2, 2015

Is this still waiting on merge conflicts to be resolved?

@fny
Copy link
Contributor Author

fny commented Oct 2, 2015

No. @laserlemon just seems uninterested in this feature. There were no conflicts when this PR was originally made, it's just been sitting around for awhile.

@Haar
Copy link

Haar commented Dec 9, 2015

Any updates on this?

@jbhatab
Copy link

jbhatab commented Jun 21, 2016

@laserlemon think this is still mergeable?

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4c2a9a8 on fny:elastic-beanstalk-support into ** on laserlemon:master**.

@bjensen
Copy link

bjensen commented Apr 12, 2017

@laserlemon Um..why hasnt this been merged already?

@taranda
Copy link

taranda commented Sep 28, 2017

It would be great to see this merged. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elastic Beanstalk Support
9 participants