fix: Limit triomphe dependency to <=0.1.10 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our SDK uses `moka` for some unit tests, which in turn has a dependency on `triomphe`. Neither of these crates provide an MSRV, resulting in their latest release breaking on rustc 1.74. To avoid bumping our own MSRV to 1.76 for now, we are going to force the triomphe dependency to be <=0.1.10. Once we bump rustc in the future, we can clean up this change.
|
Related request to add an MSRV policy. |
kinyoklion
approved these changes
May 31, 2024
keelerm84
added a commit
that referenced
this pull request
Jun 13, 2024
This reverts commit 5a52e41.
keelerm84
added a commit
that referenced
this pull request
Jun 13, 2024
This reverts commit 5a52e41.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our SDK uses
mokafor some unit tests, which in turn has a dependency ontriomphe.triomphedoes not provide an MSRV, resulting in theirlatest release breaking on rustc 1.74.
To avoid bumping our own MSRV to 1.76 for now, we are going to force the
triomphedependency to be <=0.1.10. Once we bump rustc in the future, wecan clean up this change.
BEGIN_COMMIT_OVERRIDE
chore: Limit triomphe dependency to <=0.1.10 (#83)
END_COMMIT_OVERRIDE