Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added copy-button #346

Closed
wants to merge 2 commits into from
Closed

added copy-button #346

wants to merge 2 commits into from

Conversation

omesh-omg
Copy link
Contributor

@omesh-omg omesh-omg commented Nov 16, 2023

Description
added copy button
This PR fixes #337

Building.Nighthawk._.Nighthawk.-.Google.Chrome.2023-11-19.10-45-38.mp4

I have added the button using javascript dom manipulation by searching all the code blocks and
adding the button to them in the code and than there is a CSS file for button, and also imported clipboard.min.js for copy function.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: omesh-omg <[email protected]>
Copy link

welcome bot commented Nov 16, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented Nov 16, 2023

Website preview ready!

Name Link
🔨 Latest commit e1e4b5a
🔍 Latest deploy log https://app.netlify.com/sites/getnighthawk/deploys/655a4951f2efa400081c22f9
😎 Deploy Preview https://deploy-preview-346--getnighthawk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@leecalcote leecalcote added the kind/enhancement Improvement in current feature label Nov 16, 2023
@leecalcote leecalcote requested a review from a team November 16, 2023 22:26
@Savio629
Copy link
Member

@omesh-omg
You need to change the 'Copy' text to Copy icon
Also remove the vertical scrollbar arised from your code
image

Copy link
Member

@Savio629 Savio629 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert back with unnecessary changes.

@omesh-omg
Copy link
Contributor Author

Please revert back with unnecessary changes.

@Savio629 okay

border-radius: 3px;
background-color: #009E7F;
color: #fff;
font-family: system-ui, -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen, Ubuntu, Cantarell, 'Open Sans', 'Helvetica Neue', sans-serif;
Copy link
Member

@Savio629 Savio629 Nov 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omesh-omg Replace the font-family with the one that is already in use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay see for all that you can suggest,
anything you else you find that needs attention.

@omesh-omg
Copy link
Contributor Author

@omesh-omg You need to change the 'Copy' text to Copy icon Also remove the vertical scrollbar arised from your code image

is there any specific icon for the copy button ? it can't see that in the Figma file of nighthawk,
In meshery website there is a copy icon but it is in different theme , so we can't use it here

@omesh-omg omesh-omg closed this by deleting the head repository Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement in current feature
Development

Successfully merging this pull request may close these issues.

Copy feature Enhancement
3 participants