-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added copy-button #346
added copy-button #346
Conversation
Signed-off-by: omesh-omg <[email protected]>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
✅ Website preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@omesh-omg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert back with unnecessary changes.
@Savio629 okay |
border-radius: 3px; | ||
background-color: #009E7F; | ||
color: #fff; | ||
font-family: system-ui, -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen, Ubuntu, Cantarell, 'Open Sans', 'Helvetica Neue', sans-serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omesh-omg Replace the font-family with the one that is already in use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay see for all that you can suggest,
anything you else you find that needs attention.
is there any specific icon for the copy button ? it can't see that in the Figma file of nighthawk, |
Description
added copy button
This PR fixes #337
Building.Nighthawk._.Nighthawk.-.Google.Chrome.2023-11-19.10-45-38.mp4
I have added the button using javascript dom manipulation by searching all the code blocks and
adding the button to them in the code and than there is a CSS file for button, and also imported clipboard.min.js for copy function.
Signed commits