Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Kanvas link to dropdown menu #5931

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

Tharanishwaran
Copy link
Member

@Tharanishwaran Tharanishwaran commented Sep 25, 2024

Description

This PR fixes #5894 by adding a "Kanvas" link to the dropdown menu in the Navigation component.

Notes for Reviewers

  • The link points to: Kanvas.
  • It uses the KanvasIcon.

Here’s the screenshot of the dropdown menu with the new Kanvas link:

Screenshot from 2024-09-25 14-35-06

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Sep 25, 2024

🚀 Preview for commit 82e6032 at: https://66f4117f6afcd819f3d685a7--layer5.netlify.app

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishalvivekm it seems odd to have two same icons right? // @Tharanishwaran

@Tharanishwaran
Copy link
Member Author

Tharanishwaran commented Sep 25, 2024

@sudhanshutech Thanks for pointing that out! Could you kindly suggest an alternative icon that would work better in this case?

Copy link
Contributor

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Tharanishwaran,
@sudhanshutech,
The current icon is indeed for Kanvas, which seems appropriate. If you're suggesting an alternative, could you please propose one for Playground instead? It would help to have a solution along with the suggestion. If not, let's move with the current changes for now, and it would be great if you could help design a suitable icon when possible.

@Ashparshp
Copy link
Contributor

@vishalvivekm //

@vishalvivekm vishalvivekm merged commit bdf08cb into layer5io:master Sep 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

add link to Kanvas
5 participants