Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle JSON sub-views #216

Merged
merged 4 commits into from
Sep 19, 2024
Merged

feat: Handle JSON sub-views #216

merged 4 commits into from
Sep 19, 2024

Conversation

taorepoara
Copy link
Member

@taorepoara taorepoara commented Apr 10, 2024

About this PR

Upgrade the application_runner to manage JSON sub-views. Upgrade application runner to 1.6.0.

How to test my changes

In a Lenra template create a JSON view that calls another view with the view component

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@taorepoara taorepoara marked this pull request as ready for review June 5, 2024 13:04
@taorepoara taorepoara merged commit a8cf5b1 into main Sep 19, 2024
34 checks passed
@taorepoara taorepoara deleted the json-subviews branch September 19, 2024 13:56
@shiipou
Copy link
Contributor

shiipou commented Sep 19, 2024

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants