Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCI] Clocal-gcp-Removed comments-ARK #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions examples/cloud-data-storage-client-poc/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/**
* Before running this file make sure GOOGLE_APPLICATION_CREDENTIALS variable is set
*/

const Storage = require('@google-cloud/storage');
const gcs = new Storage();
Expand All @@ -11,7 +8,7 @@ gcs.interceptors.push({
'https://www.googleapis.com',
'http://localhost:8080'
);
// console.log(JSON.stringify(reqOpts));

return reqOpts;
},
});
Expand All @@ -24,10 +21,6 @@ gcs

const bucket = await gcs.bucket('test-bucket').get();

// this endpoint doesn't work correctly
// const uploadRes = await gcs.bucket('test-bucket').upload('./test.txt');

// await gcs.bucket('test-bucket').delete();
} catch (err) {
console.log(`${err.message}`);
}
Expand Down
3 changes: 1 addition & 2 deletions src/services/cloud-functions/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM node:6.11-slim

# Create app directory
WORKDIR /usr/src/app

RUN npm install -g @google-cloud/functions-emulator
Expand All @@ -11,4 +10,4 @@ RUN mkdir /functions

COPY config.json /root/.config/configstore/@google-cloud/functions-emulator/config.json

CMD ["functions", "start", "--tail"]
CMD ["functions", "start", "--tail"]
4 changes: 1 addition & 3 deletions src/services/cloud-storage/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM node:8

# Create app directory
WORKDIR /usr/src/app

COPY package.json ./
Expand All @@ -9,11 +8,10 @@ COPY yarn.lock ./

RUN yarn

# Bundle app source
COPY . .
#TODO : copy only source files. try multiple files.
VOLUME /.clocal-gcp

EXPOSE 8080

CMD [ "npm", "start" ]
CMD [ "npm", "start" ]