feat: tournament list screen #1386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-anders
force-pushed
the
tournamentList
branch
from
ba4655b to
3f82b0a
Compare
veloce
reviewed
Feb 10, 2025
|
|
||
| @override | ||
| Widget build(BuildContext context, WidgetRef ref) { | ||
| return FutureBuilder( |
There was a problem hiding this comment.
Why using FutureBuilder instead of standard riverpod way (pattern match AsyncValue)?
There was a problem hiding this comment.
Hmm probably copy pasted from some other part of the codebase, I’ll refactor it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layout is copied from the old app for now, we can always improve it later of course
tournamentlist.webm