-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a filter to show only playing games in a broadcast round #1427
Add a filter to show only playing games in a broadcast round #1427
Conversation
ff0d3e7
to
3b3ccaa
Compare
Thanks for adding this. Do you think this menu might be a decent place to display a board count? Probably not the perfect place but not sure there's a better option as putting it on the main board tab may be considered wasted space but I def think it should be shown somewhere |
I don't think that would look good to add a board count to the scrollable bottom sheet, at least I don't see a good way to do it so I will leave it like this for now |
The problem I see here, is that one of the settings is persisted, while the other is not. I wish they were part of a different menu (or separate in another way) to mark this distinction. And I wish that any "cog" button were corresponding to persisted settings. I guess the playing game toggle could be displayed on top of the list. And to make it distinct it could be a checkbox instead of a toggle. |
I tried to replicate the choices that were made on the website. There is no distinction also on the website and I think it is fine like this because no one is going to want a persisted setting for playing games. |
I didn't say we needed to persist the settings, quite the contrary. Also the name "Playing" is not enough to understand what it is in my opinion. |
menu because it is not a persistent state
Ok I replaced it with the filter button and updated the video in the first comment |
broadcast_playing_toggle_3.webm