Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a filter to show only playing games in a broadcast round #1427

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

julien4215
Copy link
Contributor

@julien4215 julien4215 commented Feb 11, 2025

broadcast_playing_toggle_3.webm

@julien4215 julien4215 force-pushed the broadcast-playing-settings branch from ff0d3e7 to 3b3ccaa Compare February 11, 2025 12:49
@julien4215 julien4215 marked this pull request as ready for review February 11, 2025 12:53
@ijm8710
Copy link

ijm8710 commented Feb 11, 2025

Thanks for adding this. Do you think this menu might be a decent place to display a board count?

Probably not the perfect place but not sure there's a better option as putting it on the main board tab may be considered wasted space but I def think it should be shown somewhere

@julien4215
Copy link
Contributor Author

julien4215 commented Feb 12, 2025

I don't think that would look good to add a board count to the scrollable bottom sheet, at least I don't see a good way to do it so I will leave it like this for now

@veloce
Copy link
Contributor

veloce commented Feb 12, 2025

The problem I see here, is that one of the settings is persisted, while the other is not.

I wish they were part of a different menu (or separate in another way) to mark this distinction. And I wish that any "cog" button were corresponding to persisted settings.

I guess the playing game toggle could be displayed on top of the list. And to make it distinct it could be a checkbox instead of a toggle.

@julien4215
Copy link
Contributor Author

I tried to replicate the choices that were made on the website. There is no distinction also on the website and I think it is fine like this because no one is going to want a persisted setting for playing games.

@veloce
Copy link
Contributor

veloce commented Feb 12, 2025

I didn't say we needed to persist the settings, quite the contrary.

Also the name "Playing" is not enough to understand what it is in my opinion.

@veloce
Copy link
Contributor

veloce commented Feb 12, 2025

Actually I know how it should be done. With a filter button, like in the study list screen or new one I've added in the broadcast list screen.

Website has its own UI patterns, we don't have to follow them. This is an app and we need to think of making things consistent within the app.

Screenshot_1739359076

@veloce veloce changed the title Add a toggle to show only playing games in a broadcast round Add a filter to show only playing games in a broadcast round Feb 12, 2025
@julien4215
Copy link
Contributor Author

Ok I replaced it with the filter button and updated the video in the first comment

@veloce veloce merged commit b89a73e into lichess-org:main Feb 12, 2025
1 check passed
@julien4215 julien4215 deleted the broadcast-playing-settings branch February 12, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants