[sql-8]: run itests against all DB types #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
added
database
ellemouton
force-pushed
the
sql8Accounts8
branch
4 times, most recently
from
9e1bae0 to
dd41868
Compare
In this commit, we introduce a DevConfig struct which is embedded in the main lit Config struct. It is defined in two separate files that are made mutually exclusive using the `dev` build tag. The idea of this struct is that it allows us to expose additional config options to LiT if we build in a development environment such as our itests. In other words, we will be able to start developing features and testing them before making them available to users via the production build. As of this commit, both implementations of the struct are the same.
In this commit, we expand the dev build's DevConfig options struct with Postgres and SQL backend options that can be used to initialise the account store.
Add the ability to specify the db backend to run use for accounts when running itests. With this commit, you can run something like: `make itest dbbackend=sqlite`.
In this commit, we ensure that our CI runs our itests against all available DB backends. Currently, this will only affect the accounts store.
ellemouton
force-pushed
the
sql8Accounts8
branch
from
dd41868 to
5eba328
Compare
ViktorTigerstrom
approved these changes
Feb 24, 2025
bitromortac
approved these changes
Feb 24, 2025
| @@ -216,7 +216,7 @@ type LightningTerminal struct { | |||
| middleware *mid.Manager | |||
| middlewareStarted bool | |||
|
|
|||
| accountsStore *accounts.BoltStore | |||
| accountsStore accounts.Store | |||
no - it's just an artifact from the previous name (since we now longer use that name). Might mean needing to clear a GH cache or something |
|
@ViktorTigerstrom - turns out the reason was just that GH still had that old CI name listed under branch protection rules as a "Required" step. So just had to remove that and add the "Required" check for the new names :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the final step of the accounts section in phase 1 of #917
Here we run our CI itests against all DB types. As of this PR, that means that the accounts store is spun up with different DB backends for the various iterations.
(more detailed description to follow)