limactl disk: Do not use qemu-img for raw disks #3180
Draft
+42
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `limactl disk create` and `limactl disk resize` to use nativeimgutil
for creating and resizing disks using raw format.
There are special cases (using direct I/O on certain file systems) when
creating a raw image should be done with qemu-img, but these are not
relevant to lima on macOS.
With this change we have no dependency on qemu when using VZ instance.
This change does not fix the issue of default "qcow2" disk format.
Users must specify the disk format when creating additional disks for VZ
instance:
limactl disk create --format raw
Unfinished:
- Needs tests for nativeimgutil and disk command
Fixes: lima-vm#2853
Signed-off-by: Nir Soffer <[email protected]>
nirs
commented
Jan 30, 2025
nirs
force-pushed
the
limactl-disk-no-qemu
branch
from
b691ad5 to
be8ad7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
limactl disk createandlimactl disk resizeto use nativeimgutil for creating and resizing disks using raw format.There are special cases (using direct I/O on certain file systems) when creating a raw image should be done with qemu-img, but these are not relevant to lima on macOS.
With this change we have no dependency on qemu when using VZ instance.
This change does not fix the issue of default "qcow2" disk format. Users must specify the disk format when creating additional disks for VZ instance:
Unfinished:
Fixes: #2853