-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Update ubuntu runner as 20.04 is going away #3220
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Randy Fay <[email protected]>
I disagree; we want the release to maintain as much backwards compatibility as possible. The 20.04 runners don't go away until April 1st (with 4 brown-out periods before to warn people). So we might want to delay merging this PR until later in March, in case we do another patch release before then (I don't expect we will; just in case).
|
I just happened to note this since I had a checkout on my machine and grepped for all the ubuntu-20.04 usages :) |
What symbols are we requiring? Could we add some hack for backwards compability, in that case? https://gcc.gnu.org/wiki/SymbolVersioning (I can't seem to find anything but I still think 22.04 is the desired target. I was just wondering, where it breaks. EDIT: that would be: 2.2.5 - 2.3.4
When compiled with glibc 2.31 |
I don't know, but I think this is because we compile with |
Yeah, the go change was a problem for alpine (since it doesn't use glibc, and didn't have libresolv) Just wondered if it was a big problem, but then again probably only affects RHEL 8 (2018) and such? This project had some nice tables and workarounds: https://github.com/pypa/manylinux |
My head hurts just looking at that... I think just building our releases on the oldest Ubuntu version that has supported GitHub runners is good enough. If platforms still need special consideration beyond that, then ideally they should distribute Lima through their package system. Or users can compile it themselves: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Ubuntu 20.04 is going to be turned off shortly as a host runner.
Use 22.04 instead. The note though may imply problems:
# An old release of Ubuntu is chosen for glibc compatibility
IMO it might be better to just use ubuntu-latest and remove the comment?