Fix incorrect firmware path suggestion for aarch64 in qemu.go #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AkihiroSuda @msgilligan , made the told changes , thanks for the review. |
|
Thanks, but please sign the commit for DCO (run |
Previously, the error message in qemu.go incorrectly suggested copying "edk-/usr/bin/qemu-system-aarch64-code.fd" instead of the correct firmware file, "edk-aarch64-code.fd". This was due to qemuExe containing the full path to the QEMU binary instead of just the architecture name. This commit ensures that only "aarch64" is used in the error message, resulting in the correct suggestion: "edk-aarch64-code.fd". Signed-off-by: Kairvee Vaswani <[email protected]>
done , it was new thing learnt , thanks @AkihiroSuda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes (#3154)
Previously, the error message in qemu.go incorrectly suggested copying "edk-/usr/bin/qemu-system-aarch64-code.fd" instead of the correct firmware file, "edk-aarch64-code.fd". This was due to qemuExe containing the full path to the QEMU binary instead of just the architecture name.
This commit ensures that only "aarch64" is used in the error message, resulting in the correct suggestion: "edk-aarch64-code.fd".