Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/generic #30

Merged
merged 51 commits into from
Sep 13, 2023
Merged

Feature/generic #30

merged 51 commits into from
Sep 13, 2023

Conversation

lindsaygelle
Copy link
Owner

@lindsaygelle lindsaygelle commented Sep 13, 2023

Description

Complete refactor of the code to use Go generics. Removes all wrapped subsets. Allows for concrete testing of the definitive type and repetition of code.

Related Issue

Moving to Go generics.

Changes Made

Removes all previous versions.

How to Test

go test ./...

Checklist

  • I have followed the coding style guidelines of the project.
  • My code passes all existing unit tests.
  • I have added new unit tests to cover the changes where applicable.
  • I have updated the documentation to reflect the changes.
  • My changes do not introduce any new warnings or errors.
  • I have tested my changes thoroughly.

Additional Notes

Adding tests.

Copy link
Owner Author

@lindsaygelle lindsaygelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚧 👷

Copy link
Owner Author

@lindsaygelle lindsaygelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏗️

Copy link
Owner Author

@lindsaygelle lindsaygelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a day!

@lindsaygelle lindsaygelle merged commit 743802c into main Sep 13, 2023
6 checks passed
@lindsaygelle lindsaygelle deleted the feature/generic branch September 13, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant