-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade swc_core to v5.0.4 #144
feat: Upgrade swc_core to v5.0.4 #144
Conversation
…hain@v1 action and defer to rust-toolchain.toml for targets, etc
Thanks! I prefer to not jump over a few versions at once, because this will limit compatibility with other runtimes. According to the https://plugins.swc.rs/versions/range/116 we need to issue a version with [email protected] - < 6.0.0 to support latest nextjs and then do a second release with [email protected] I can take it over from here. Thanks for contributing and updating rust tooling. @andrii-bodnar FYI, we need to relese two bumps consequentally, one with [email protected] - < 6.0.0 and another with v13.3.0. I will prepare PR for the first one. |
I pushed downgrade to v5 directly to this PR's branch. Also the full range for v1.2.3 and 1.2.4 of Rspack is |
@jeremywiebe thanks for the contribution! @timofei-iatsenko so I'll release the |
the next bump #146 |
Thank you for taking this over and landing it. This’ll open up the newest version of Rspack and the ability to use DebugIDs in production. Thanks again. |
In this PR we upgrade the
swc_core
crate to v13.3.0. This makes the plugin compatible with v1.2.3 and 1.2.4 of Rspack which will allow projects using this plugin to upgrade.A few things of note:
swc_core
. The major changes are documented at the top of this page: https://swc.rs/docs/plugin/ecmascript/getting-startedactions-rust-lang/setup-rust-toolchain@v1
which is a newer, more advanced version of the action this project was already using. It will respect the values inrust-toolchain.toml
reducing how many times the toolchain needs to be specifiedLinguiMacroFolder
needed to be wrapped infold_pass()
calls in tests to be compatible with the new parameter list thattest_inline!
expects.Once these changes were complete, all tests passed and I was able to install this plugin in a real project that uses Rspack and build it successfully.