Skip to content

Commit

Permalink
Allow configuring externalTrafficPolicy (#13016)
Browse files Browse the repository at this point in the history
The linkerd-multicluster helm chart does not allow changing the externalTrafficPolicy of the linkerd-gateway Service

Add serviceExternalTrafficPolicy to allow changing the value in the deployed service if needed.

Deploying the linkerd-multicluster chart with "serviceExternalTrafficPolicy: Local" will make the Service to be deployed with `externalTrafficPolicy: Local`

Fixes #13015

Signed-off-by: Lauri Kuittinen <[email protected]>
  • Loading branch information
lauriku authored Sep 6, 2024
1 parent 81d7c9f commit ab207aa
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions multicluster/charts/linkerd-multicluster/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ Kubernetes: `>=1.22.0-0`
| gateway.probe.seconds | int | `3` | The interval (in seconds) between liveness probes |
| gateway.replicas | int | `1` | Number of replicas for the gateway pod |
| gateway.serviceAnnotations | object | `{}` | Annotations to add to the gateway service |
| gateway.serviceExternalTrafficPolicy | string | `""` | Set externalTrafficPolicy on gateway service |
| gateway.serviceType | string | `"LoadBalancer"` | Service Type of gateway Service |
| gateway.terminationGracePeriodSeconds | string | `""` | Set terminationGracePeriodSeconds on gateway deployment |
| gateway.tolerations | list | `[]` | Tolerations for the gateway pod |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,9 @@ spec:
selector:
app: {{.Values.gateway.name}}
type: {{ .Values.gateway.serviceType }}
{{- with .Values.gateway.serviceExternalTrafficPolicy }}
externalTrafficPolicy: {{ . }}
{{- end }}
{{- if .Values.gateway.loadBalancerClass }}
loadBalancerClass: {{ .Values.gateway.loadBalancerClass }}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions multicluster/charts/linkerd-multicluster/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ gateway:
seconds: 3
# -- Annotations to add to the gateway service
serviceAnnotations: {}
# -- Set externalTrafficPolicy on gateway service
serviceExternalTrafficPolicy: ""
# -- Annotations to add to the gateway deployment
deploymentAnnotations: {}
# -- Set loadBalancerClass on gateway service
Expand Down

0 comments on commit ab207aa

Please sign in to comment.