Simplify State Management RFC #35
Open
+209
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
alpeb
reviewed
Aug 25, 2020
Comment on lines
+16
to
+20
| Currently, Linkerd state in the `linkerd-config` ConfigMap as flags parsed from `installOptions`. | ||
| This has become counter intuitive after we added Helm support as `Values` struct | ||
| became our main source of truth (for rendering, etc), and causing back and forth | ||
| conversions between `installOptions` and `Values`. This RFC aims to remove the | ||
| unnecessary complexity in managing state and simplify things. |
There was a problem hiding this comment.
I think it's worth framing the problem at first a little less technically, clarifying that the goal is to simplify state management for upgrades
Signed-off-by: Tarun Pothulapati <[email protected]>
6 tasks
|
This was accidentally closed when we changed the default branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered RFC
Summary
Currently, Linkerd state in the
linkerd-configConfigMap as flags parsed frominstallOptions.This has become counter intuitive after we added Helm support as
Valuesstructbecame our main source of truth (for rendering, etc), and causing back and forth
conversions between
installOptionsandValues. This RFC aims to remove theunnecessary complexity in managing state and simplify things.
Problem Statement (Step 1)
Currently,
linkerd-configconfigMap is not only used for upgrades but also bymultiple components like Proxy Injector, CLI, etc to understand the current
cluster/linkerd state. This has the following problems:
installOptionsand
Values.Valuesis not the source of truth, hacks had to be/beingmade to make state (outside of flags, etc) to be stored and retrieved.
Signed-off-by: Tarun Pothulapati [email protected]