Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT overlay support #382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ludiazv
Copy link

@ludiazv ludiazv commented May 30, 2023

Experimental feature to include DT overlays and custom boot args

Usage and implementation details are documented in the README

Experimental feature to include DT overlays and custom boot args
@ludiazv ludiazv mentioned this pull request May 30, 2023
@nandra
Copy link
Collaborator

nandra commented Jun 1, 2023

@ludiazv Thanks for this. I need to sit and read it properly, but no time now. Maybe next week. Thanks again.

@ludiazv
Copy link
Author

ludiazv commented Jun 1, 2023

No worries. Let me know if you have any doubt about the implementation.

@nandra
Copy link
Collaborator

nandra commented Jul 13, 2023

@ludiazv It took a while :) but in general I'm OK with approach. Few comments:

  • I would rename sunxienv to something more descriptive
  • other thing would be to push overlays to separate repo and fetch during building (I don't want to have meta-sunxi changed all the time when someone need update of dtbo)

I'm open for discussion ;). Thanks.

@ludiazv
Copy link
Author

ludiazv commented Jul 17, 2023

Hi @nandra,

@ludiazv It took a while :) but in general I'm OK with approach. Few comments:

  • I would rename sunxienv to something more descriptive

I see no problem on that. something like boot.txtcould be fine. Other option is to set a bitbake variable that can be changed by the user of the layer with a weak default vaule. e.g. SUNXI_BOOT_FILENAME ?= "boot.txt"

  • other thing would be to push overlays to separate repo and fetch during building (I don't want to have meta-sunxi changed all the time when someone need update of dtbo)

I'm agree, is much more versatile having two repositories and change recipe to fetch the files from there. Are you able to create a repo under linux-sunxi? If that the case I think you can be eassyly port the example files I included as a proof or concept.

I'm open for discussion ;). Thanks.

@nandra
Copy link
Collaborator

nandra commented Jul 31, 2023

@ludiazv got response from Paul (one of the repo maintainers) that best would be to post overlays to mainline e.g.: https://patchwork.kernel.org/project/linux-media/patch/[email protected]/

Can you do it or should I? Thanks.

@ludiazv
Copy link
Author

ludiazv commented Aug 2, 2023

If that's possible it would be better. I don't know how to do it. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants