Implement timeout for whole metrics send function #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw occasional slowness from the mist GetState function. The mist client has a 1 minute timeout and we need a much shorter timeout here as the loop runs every 5 seconds
|
The diff is best viewed with whitespace hidden |
leszko
approved these changes
Feb 5, 2025
| sysusage, err := GetSystemUsage() | ||
| if err != nil { | ||
| log.LogNoRequestID("catabalancer failed to get sys usage", "err", err) | ||
| done := make(chan bool) |
There was a problem hiding this comment.
I think the more "golang way" of doing the same would be passing context with timeout into sendMetrics(). So you could have something like this:
ctx, cancel := context.WithTimeout(context.Background(), timeout)
sendMetrics(ctx, nodeName, latitude, longitude, mist, nodeStatsDB)And then inside sendMetrics() to have
GetSystemUsage(ctx)And so on. The good thing about this approach would be that in case of the timeout you cancel all system and network calls.
mjh1
force-pushed
the
mh/catabalancer
branch
3 times, most recently
from
91129cb to
7c9b496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw occasional slowness from the mist GetState function. The mist client has a 1 minute timeout and we need a much shorter timeout here as the loop runs every 5 seconds