fix #998 : prevent caching of route callbacks #1002
+36
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #998 .
Before:
php artisan route:cache
serializes through reflection the route callbacks, hardwiring the execution context's absolute path to flux's asset files (ex: /Users/vorban/repositories/...) because of__DIR__
resolution.After:
php artisan route:cache
serializes references to the route actions, preventing any resolution of__DIR__
before runtime.I've tested it locally. The routes are listed by
artisan route:list
, andartisan route:cache
correctly serialized references to the functions.After a
route:cache
, going to any page that uses the blade directives like@fluxStyles
works and the files are correctly fetched.I'd prefer this to be thoroughly reviewed, as I failed to find the contribution guidelines and test suites to run.