worker.py: Avoid letting a job get stuck if exception occurs #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some instances of stuck jobs were observed recently for PureOS. From the logs, I think a Python exception may have occurred after the build completed but before the artifacts were uploaded. I can't tell what might have caused that exception, if it did occur.
This change would ensure that a 'rejected' status is sent if this occurs, rather than leaving the job stuck with no result.
I applied this change to fennel.pureos.net (the new worker) to try to identify what was causing the stuck jobs, but this never happened again. No jobs got stuck after that and this exception code was never hit, so I can't identify the root cause.