Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish image with github actions #47

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

wozz
Copy link
Contributor

@wozz wozz commented Jan 10, 2024

setup GitHub actions to publish the image. if I understand correctly, the backups include the image when it's not published, so by publishing the image, backup size should be reduced

@loganmarchione loganmarchione merged commit 3b6fefd into loganmarchione:main Jan 11, 2024
2 checks passed
@loganmarchione
Copy link
Owner

Thanks @wozz! I had struggled with how to do this since I may eventually add new add-ons to this repo. I like your use of --target so that it only targets the prometheus_node_exporter directory.

It was a seamless upgrade for me from 0.8.0 to your 0.8.1 release, thanks!

@wozz
Copy link
Contributor Author

wozz commented Jan 12, 2024

I probably should have commented a bit more about it...

The main build action is using this marketplace action: https://github.com/marketplace/actions/home-assistant-builder

The other component is the version check - the builder script home-assistant provides doesn't work to check GHCR versions, so I added that part in my own add-on repo and then copied it here. (I wanted to avoid setting up an extra account on docker hub since GitHub already provides a container registry.)

With the version check, the image should only be released when the config file version is changed.

Figured it would be easier to copy my setup for your repo than fork this add-on just for the ~20mb savings in my backups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants