Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gitignore #1071

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

theopomies
Copy link

Adds support for filtering out gitignored files

This feature adds a --gitignore CLI flag and a gitignore (optional) boolean key in the config file for filtering out gitignored files.

It makes use of the GitStatus and GitCache structures to provide this feature.

I wrote tests for the Config and Cli flag but couldn't figure out how to write integration tests, I didn't find any tests for the GitStatus or IgnoreGlobs features to take inspiration from.

This partially solves #218 and #342

TODO

  • Use cargo fmt
  • Add necessary tests
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@theopomies theopomies requested a review from zwpaper as a code owner July 5, 2024 08:09
@muniu-bot muniu-bot bot added the size/L label Jul 5, 2024
Copy link

muniu-bot bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: theopomies
Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@theopomies theopomies marked this pull request as draft July 5, 2024 08:26
@theopomies theopomies marked this pull request as ready for review July 5, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant