Tickets/sitcom 1689 - Facilities Temperatures report #14
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,442 @@ | |||
| { | |||
There was a problem hiding this comment.
Maybe add a couple of sentences description here of what are the 3/4 temperature sensors about.
Reply via ReviewNB
| @@ -0,0 +1,442 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I removed this part. The telemetry from MTMount showed to be unliable. I noticed that the temperature reported by MTMount could change by a degree after a state transition. On top of it, it was way too stable for our analysis.
| @@ -0,0 +1,442 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #68. heights = {
Are these heights being used? And then the actual heights in the plots seem a bit arbitrary to me. I don't know why Standby should be on top for instance. Makes more sense for the heights to be the ones you have here but they are not used.
Reply via ReviewNB
There was a problem hiding this comment.
They were at some point. I removed them.
| @@ -0,0 +1,442 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #89. ax2.scatter(df_mtmount.index, df_mtmount["summaryState"], marker='|')
The marker could be an 'x' for better visibility.
Reply via ReviewNB
There was a problem hiding this comment.
I tried marker 'x'. However, they overlap a lot. Hence, the choice of '|'. However, I believe this part of the plot will go away.
| @@ -0,0 +1,442 @@ | |||
| { | |||
There was a problem hiding this comment.
Optional really: add more formatting to the output table, so that the time column is Time (UTC) and the temperatures are C, with two significant figures. Same for the other cells below.
Reply via ReviewNB
b1quint
force-pushed
the
tickets/SITCOM-1689
branch
from
29ec2df
to
1e9e7ee
Compare
- Now the plot shows mtmount state transitions - day_obs is a string and it will be converted into int to ensure that the notebook will work properly
It seems that the M1M3TS glycol temperatures provide a better estimate of the temperature inside the cell. This might change again.
b1quint
force-pushed
the
tickets/SITCOM-1689
branch
from
2a6640a
to
de769f9
Compare
b1quint
force-pushed
the
tickets/SITCOM-1689
branch
from
78215be
to
12417d4
Compare
No description provided.