Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets/sitcom 1380 #6

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Tickets/sitcom 1380 #6

merged 4 commits into from
Sep 2, 2024

Conversation

nsevilla
Copy link
Contributor

@nsevilla nsevilla commented Jun 7, 2024

I am still waiting from a couple of sign offs of their respective technotes, but I think this is ready for review.

@nsevilla nsevilla requested a review from b1quint June 7, 2024 06:40
@nsevilla nsevilla requested a review from kakoon June 20, 2024 16:15
b1quint
b1quint approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@b1quint b1quint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nacho! I finally had a chance to look at this. I apologize for the delay. It looks good. The summaries are all clear. I believe we are good to merge this.

@dsanmartim dsanmartim force-pushed the tickets/SITCOM-1380 branch 2 times, most recently from f661551 to b8d3047 Compare August 29, 2024 16:31
@nsevilla nsevilla merged commit b8965f5 into main Sep 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1quint b1quint b1quint approved these changes

@kakoon kakoon Awaiting requested review from kakoon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsevilla @b1quint @dsanmartim