-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tickets/sitcom 1120 Simple Conversion of Jupyternotebook. #1
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi Yijung ! Thanks for this conversion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A simple conversion is fine. I would suggest removing Case 3 and Case 4 at the end of the page, as they are not necessary for the general purpose of this script.
I changed the TN to old style (not using the ipynb) and Dominique reviewed. |
I have changed the assignee to myself, and reviewer to Dominique |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed some details with HyeYun on Slack. Everything is fine now.
Approved |
Closed pull request by mistake, reopened. |
I directly converted the Jupyter Notebook to the technote for this version as there would be a chance that we need this notebook very soon.
https://sitcomtn-143.lsst.io/v/SITCOM-1120/index.html
Now I am thinking that I will use tags (what you showed me before) so
v0.1 - simply converted one from the original notebook (this version)
For v.0.2 - apply TN-102 structure with a little more description.