Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/sitcom 1120 Simple Conversion of Jupyternotebook. #1

Merged
merged 15 commits into from
Jan 24, 2025

Conversation

ykangastro
Copy link
Contributor

I directly converted the Jupyter Notebook to the technote for this version as there would be a chance that we need this notebook very soon.

https://sitcomtn-143.lsst.io/v/SITCOM-1120/index.html

Now I am thinking that I will use tags (what you showed me before) so

v0.1 - simply converted one from the original notebook (this version)

For v.0.2 - apply TN-102 structure with a little more description.

  1. move some functions to the separated Python code (and call the functions)
  2. add an abstract, some background, and more descriptions
  3. add just a few more descriptions and apply some structure on tn-102

@ykangastro ykangastro self-assigned this Oct 25, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@PaulinaLSST
Copy link
Contributor

Hi Yijung ! Thanks for this conversion.

@PaulinaLSST PaulinaLSST reopened this Nov 19, 2024
Copy link
Contributor

@PaulinaLSST PaulinaLSST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple conversion is fine. I would suggest removing Case 3 and Case 4 at the end of the page, as they are not necessary for the general purpose of this script.

@PaulinaLSST PaulinaLSST self-requested a review January 8, 2025 00:57
@kakoon kakoon assigned kakoon and unassigned ykangastro Jan 21, 2025
@kakoon kakoon requested review from boutigny and removed request for b1quint and PaulinaLSST January 21, 2025 19:32
@kakoon
Copy link
Contributor

kakoon commented Jan 21, 2025

I changed the TN to old style (not using the ipynb) and Dominique reviewed.

@kakoon
Copy link
Contributor

kakoon commented Jan 21, 2025

I have changed the assignee to myself, and reviewer to Dominique

@kakoon kakoon requested review from PaulinaLSST and removed request for PaulinaLSST January 21, 2025 19:34
Copy link

@boutigny boutigny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed some details with HyeYun on Slack. Everything is fine now.

@PaulinaLSST
Copy link
Contributor

Approved

@PaulinaLSST PaulinaLSST reopened this Jan 22, 2025
@PaulinaLSST
Copy link
Contributor

Closed pull request by mistake, reopened.

@PaulinaLSST PaulinaLSST removed their request for review January 22, 2025 14:23
@kakoon kakoon merged commit 3624816 into main Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants