DM-47531: refactor, test, and add ArrowAstropy support to ForcedPhotCcdTask. #292
+503
−231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForcedPhotCcd can now take DataFrame inputs by setting its refCatStorageClass config parameter appropriately. It also now has config parameters for the columns it expects from the ref cat. ForcedPhotCcdFromDataFrameTask still exists for backwards compatibility, but now it's a trivial subclass that only sets some config defaults.
TallJimbo
force-pushed
the
tickets/DM-47531
branch
from
974a67f
to
e5e9e69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.