DM-46919: Extend the http frontend of Qserv to support pushing CSV files in the multipart/form-data body #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iagaponenko
force-pushed
the
tickets/DM-46919
branch
6 times, most recently
from
ba72521
to
f8b0c67
Compare
jgates108
approved these changes
Nov 14, 2024
doc/admin/data-table-indexes.rst
Outdated
| types (numeric, etc.). Otherwise, an index creation request will fail. | ||
|
|
||
| ``ascending`` : *number* | ||
| The required sorting order of the column in the index. It translates into ``ASC`` or ``DESC`` optiona |
doc/admin/data-table-indexes.rst
Outdated
| The required *base* name of the table where the index will be created. | ||
|
|
||
| ``overlap`` : *number* := ``0`` | ||
| The optional *overlap* flagg indicating a sub-type of the *chunk* table. The value should be one of the following: |
doc/admin/data-table-indexes.rst
Outdated
| ``table`` : *string* | ||
| The name of the table for which the indexes are required to be collected. | ||
|
|
||
| The optional query parameyter is |
doc/admin/data-table-indexes.rst
Outdated
| The optional query parameyter is | ||
|
|
||
| ``overlap`` : *number* := ``0`` | ||
| The optional *overlap* flagg indicating a sub-type of the *chunk* table. The value should be one of the following: |
| | "longitude_key" : "dec" | | | ||
| | } | **Note**: Attributes ``latitude_key`` and | | ||
| | | ``longitude_key`` were not provided. | | ||
| | | is allowed for the dependent tables. | |
| * @param databaseName The name of the database to be verified. | ||
| * @throw http::Error if the name is too short, or it doesn't start with the required prefix. | ||
| */ | ||
| void verifyUserDatabaseName(std::string const& func, std::string const& databaseName) const; |
There was a problem hiding this comment.
I think this could be static.
| * @param tableName The name of the table to be verified. | ||
| * @throw http::Error if the name is too short, or it starts with the reserved prefix. | ||
| */ | ||
| void verifyUserTableName(std::string const& func, std::string const& tableName) const; |
There was a problem hiding this comment.
I think this could be static.
| // Some value of the parameters are still required by the Replication/Ingest system's API. | ||
| unsigned int defaultNumStripes = 340; | ||
| unsigned int defaultNumSubStripes = 3; | ||
| float defaultOverlap = 0.01667; |
There was a problem hiding this comment.
These appear to be placeholder values that aren't really used? It would be nice to get rid of them to prevent future confusion.
| json data = json::object({{"database", databaseName}, | ||
| {"num_stripes", ::defaultNumStripes}, | ||
| {"num_sub_stripes", ::defaultNumSubStripes}, | ||
| {"overlap", ::defaultOverlap}}); |
There was a problem hiding this comment.
The comment at definition of these values leads me to believe they have no real effect here. Maybe they should have have values that indicate that? A replicated table effectively has 0 stripes, 0 substripes, and 0 overlap. If it's a partioned tables, these should be real values.
| Request::Request(function<Result()> const& req, shared_ptr<ResultQueue> resultQueue) | ||
| : _req(req), _resultQueue(resultQueue) {} | ||
|
|
||
| void Request::operator()() { _resultQueue->push(_req()); } |
There was a problem hiding this comment.
I have a minor complaint about operator()(). It can be very difficult to find all instances where it is called when the ide isn't doing a good job. grep "()" generates vast numbers of false positives.
…tted requests The new version of the class allows sending file attachments in the streaming mode, along with parts.
The rafactoring prepares ground for introducing another implementation of the REST API for ingesting tables in the "multi-part/form" body. The new intermediate base class will prevent code duplication after adding the second module.
Refactored the command line application qserv-czar-http to use Boost options for command line parsing. Extended the integration test scripts and the configuration file accordingly.
iagaponenko
force-pushed
the
tickets/DM-46919
branch
from
f8b0c67
to
4b08a3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.