Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in websocket-extension.md #1437

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kenricashe
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kenricashe
❌ actions-user
You have signed the CLA already but the status is still pending? Let us recheck it.

@kenricashe
Copy link
Contributor Author

I don't know how to get "actions-user" to sign the CLA hahaha and ... those Lint failures? Well I only edited one file and ironically it was to fix spelling, grammar, and other typos! So I don't know why the lint checks are failing, but I'm guessing they'd be failing for everyone's pull requests?

@@ -883,7 +883,7 @@
"file": "websocket-extension.md",
"title": "WebSocket Extension",
"path": "/docs/recipes/websocket-extension.md",
"hash": "1238504767ae21551d1f1e00870b271b",
"hash": "2b955c949e9e1febc10b6ef51ec8c5a0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't have to change the index, that is created by github action on commit

@@ -258,7 +258,7 @@ Lucee supports the following virtual file systems: ram, file, s3, http, https, z

## [WebSocket Extension](/docs/recipes/websocket-extension.md)

How to install, congigure and create WebSockets
How to install, configure and create WebSockets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't have to change the readme, that is created by github action on commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants