feat(lucide-react): Add DynamicIcon component #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📖 documentation
github-actions
bot
added
📦 dependencies
…into dynamic-imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2366
Closes #2269
Closes #1828
Closes #1767
Closes #1730
Closes #1725
Closes #1576
Closes #2030
Closes #2437
What is the purpose of this pull request?
Description
Adding the
DynamicIconcomponent, this will make the framework specific ways of working with Dynamic imports not an issue since the DynamicIcon is working standalone.Difference with current
dynamicIconImportsfile.Currently, it exports a map of all icon components. The
DynamicIconuses the same map, but is not using the components but only theicon nodesand renders the icon in the DynamicIcon.In the future we will expose a different package wich exposes the dynamic imports with IconNodes, this will be available for other packages as well.
TODO: