fix(lucide): Support for iconNodes from other libs like Lab #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport--regular-iconNodes-lucide
ericfennis
changed the title
…m/lucide-icons/lucide into support--regular-iconNodes-lucide
|
Hi @ericfennis , I've just updated lucide to the latest version. It seems like with this change breaks normal usage of createElement with just lucide. https://lucide.dev/guide/packages/lucide#custom-element-binding import { createElement, Menu } from 'lucide';
const menuIcon = createElement(Menu);
// ^-- Type and Runtime error here |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2300
What is the purpose of this pull request?
Description
Adds support for iconNodes from other libraries like Lucide Lab.
It also reduces the bundle size by removing unnecessary code