Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added mouse-right icon #2787

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marvfash
Copy link

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

This icon is an extension of the mouse icon to show specific button interaction.

Icon use case

  • Can be used to indicate the right mouse button instead of the generic mouse icon.
  • Indicating clickable objects.
  • Representing key bindings or interaction

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.x
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: mouse
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

Comment on lines +12 to +17
<path d="M 19 10 L 19 14.999" />
<path d="M 19 14.999 A7 7 0 0 1 5 14.999" />
<path d="M 5 14.999 L 5 8.999" />
<path d="M 5 8.999 C5 5.473 7.608 2.485 11 2" />
<path d="M12 10v1" />
<circle cx="17" cy="4" r="2" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #2788 (comment) (plus further optimizations):

Suggested change
<path d="M 19 10 L 19 14.999" />
<path d="M 19 14.999 A7 7 0 0 1 5 14.999" />
<path d="M 5 14.999 L 5 8.999" />
<path d="M 5 8.999 C5 5.473 7.608 2.485 11 2" />
<path d="M12 10v1" />
<circle cx="17" cy="4" r="2" />
<path d="M12 7.318V10" />
<path d="M19 10v5a7 7 0 0 1-14 0V9c0-3.527 2.608-6.515 6-7" />
<circle cx="17" cy="4" r="2" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants