Fixed Leaderboard Search a bit #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WizzyGeek
requested changes
Jan 11, 2025
| .select() | ||
| .order("points", { ascending: false }); | ||
| if (error) throw error; | ||
| setOriginalData(data); |
There was a problem hiding this comment.
You can just modify the function defined in the outer scope instead of redfining it to add this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the search would not work properly if you entered a wrong string and then fixed it due to directly modifying the data and not preserving it.
This is how it worked originally:
https://github.com/user-attachments/assets/936cd32f-e3fa-442f-a839-7904998421ee
After changes:
https://github.com/user-attachments/assets/a026a258-4b20-4c62-8379-aa028bef9073