Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Add breadcrumbs component #3145

Merged
merged 12 commits into from
Oct 18, 2024
Merged

frontend: Add breadcrumbs component #3145

merged 12 commits into from
Oct 18, 2024

Conversation

septum
Copy link
Contributor

@septum septum commented Oct 16, 2024

Description

  • Added Breadcrumbs component

PRs

Screenshots

Before

localhost_3000_catalog_clutch

After

localhost_3000_catalog

Testing Performed

Manual

@septum septum requested a review from a team as a code owner October 16, 2024 21:29
Copy link
Contributor

@jdslaugh jdslaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! From the image it looks like the last entry is getting the link applied, is that happening? I assume it's from test data but want to make sure.

Also, is this actually reliant on workflow-layout? Don't see anything related to it. So it could go in separately.

@septum
Copy link
Contributor Author

septum commented Oct 17, 2024

Looks good! From the image it looks like the last entry is getting the link applied, is that happening? I assume it's from test data but want to make sure.

Also, is this actually reliant on workflow-layout? Don't see anything related to it. So it could go in separately.

It was used for testing only, I'll make sure to retest after the merge of #3143

Copy link
Contributor

@jecr jecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments

Base automatically changed from workflow-layout to main October 18, 2024 17:58
@septum septum merged commit 56d96b2 into main Oct 18, 2024
8 checks passed
@septum septum deleted the breadcrumbs branch October 18, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants