Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: Generate breadcrumbs inside workflow layout #3149

Merged
merged 3 commits into from
Oct 21, 2024
Merged

frontend: Generate breadcrumbs inside workflow layout #3149

merged 3 commits into from
Oct 21, 2024

Conversation

septum
Copy link
Contributor

@septum septum commented Oct 18, 2024

Description

  • Renders breadcrumbs component and generate valid entries inside the workflow layout

Screenshots

Screenshot 2024-10-18 at 4 12 51 p m
Screenshot 2024-10-18 at 4 13 00 p m
Screenshot 2024-10-18 at 4 13 06 p m
Screenshot 2024-10-18 at 4 13 41 p m

Testing Performed

Manual

@septum septum requested a review from a team as a code owner October 18, 2024 22:14
jecr
jecr approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@jecr jecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this and the recent updates to the layout impact the template files used by the scaffolding tool?

@septum
Copy link
Contributor Author

septum commented Oct 21, 2024

Will this and the recent updates to the layout impact the template files used by the scaffolding tool?

It seems that it will need a new property layout in the configuration, I'll create a ticket. Thanks for the heads up!

@septum septum merged commit f24f53d into main Oct 21, 2024
8 checks passed
@septum septum deleted the generate-breadcrumbs branch October 21, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jecr jecr jecr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@septum @jecr