Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #61

Closed
wants to merge 1 commit into from
Closed

Update README.md #61

wants to merge 1 commit into from

Conversation

Pomax
Copy link

@Pomax Pomax commented Oct 20, 2023

this does not need to be installed globally.

this does not need to be installed globally.
@adminy
Copy link

adminy commented Jan 9, 2024

I find it particularly useful to use it this way:

timeout -s SIGUSR1 3m node -r why-is-node-running/include myscript.js

could be also added to readme. This just tells you what's wrong if the program is stuck after 3m of operation.

@Pomax
Copy link
Author

Pomax commented Jan 9, 2024

probably something you'll want to write your own PR for, so that @mafintosh can make decisions and leave comments on them separately.

@adminy
Copy link

adminy commented Jan 10, 2024

Done in #63

@jonkoops
Copy link
Collaborator

Thanks for the PR. I've updated the installation options to reflect global installation as an optional choice under #74, so I will close this one.

@jonkoops jonkoops closed this Jul 12, 2024
@Pomax
Copy link
Author

Pomax commented Jul 12, 2024

@jonkoops cheers. Small note: the use of short flags is pretty universal, so telling folks to use -D or -g is nicer than the rather verbose full name flags with extra dashes.

@jonkoops
Copy link
Collaborator

Thanks for the feedback, but I disagree. You never know the skill level of the person installing your packages, so it's best to assume that they don't know the meaning of any of these shorthands. Giving them the more verbose version adds extra clarity, and for those that already know the commands there isn't really that much contextual overhead. I'd rather be a bit more verbose here if that means it is inclusive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants