Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript types #62

Closed

Conversation

QAComet
Copy link

@QAComet QAComet commented Nov 22, 2023

I added a basic typescript interface so I could run this package in one of my projects. Now in typescript I can use

import whyIsNodeRunning from 'why-is-node-running';

async function errorFunc () : void {
  // ...
  whyIsNodeRunning();
}

@jonkoops
Copy link
Collaborator

jonkoops commented Jul 8, 2024

Hi @QAComet, thanks for your PR. In the mean time we've changed the package use JavaScript modules, so I don't think the types here are correct any longer as they use a namespace. I'll go ahead an close this PR for now, but I intend to add types going forward.

@jonkoops jonkoops closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants